Repository navigation
TST: Move 32-bit and parallel job to Actions - #11043
Merged
Merged
Conversation
18 tasks done
pllim
commented
Nov 14, 2020
| image: quay.io/pypa/manylinux1_i686 | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 |
Member
Author
There was a problem hiding this comment.
Looks like this doesn't work with container?
/usr/bin/docker exec .... sh -c "cat /etc/*release | grep ^ID"
OCI runtime exec failed: exec failed: container_linux.go:370: starting container process caused: no such file or directory: unknown
Member
Author
There was a problem hiding this comment.
Looks like a known and unresolved issue at actions/checkout#334
Member
Author
Member
Author
|
Is there anything that is blocking this? |
astrojuanlu
reviewed
Nov 25, 2020
astrojuanlu
approved these changes
Nov 25, 2020
astrojuanlu
left a comment
astrojuanlu
left a comment
Member
There was a problem hiding this comment.
The Actions spec looks like a good translation of the Circle CI one. I went over the Actions logs and didn't spot anything suspicious.
Contributor
|
I don't see a reason to delay this, so let's merge! Thanks @pllim. |
Member
Author
|
Thanks for the reviews, y'all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to move "32-bit and parallel" job from CircleCI to GitHub Actions. I purposely let the full CI run to make sure I didn't mess up CircleCI config. (CircleCI seems to work as expected in the first commit, so now I will skip it.)
There were talks about we should stop using Docker image or something but I am not sure what to do with that part.
This is a follow up of #10388 and address part of #11038 .