Skip to content

TST: Add back --open-files to one job - #11037

Merged
pllim merged 2 commits into
astropy:masterfrom
pllim:actions-open-files
Nov 13, 2020
Merged

TST: Add back --open-files to one job#11037
pllim merged 2 commits into
astropy:masterfrom
pllim:actions-open-files

Conversation

@pllim

@pllim pllim commented Nov 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This pull request is to investigate if we can still use --open-files.

This is a follow up of #10388

@pllim pllim added this to the v4.3 milestone Nov 12, 2020
@pllim pllim mentioned this pull request Nov 12, 2020
Closed
@pllim

pllim commented Nov 13, 2020

Copy link
Copy Markdown
Member Author

Seems to work but I just don't know if adding --open-files to the job that also measures duration will mess up the latter. What do you think, @astropy/devops-maintainers @astrofrog @saimn et al?

@pllim pllim mentioned this pull request Nov 13, 2020
Closed
18 tasks done
@astrofrog

astrofrog commented Nov 13, 2020

Copy link
Copy Markdown
Member

Yeah it definitely doesn't make sense to have the one that mesures durations be the same one.

@pllim

pllim commented Nov 13, 2020

Copy link
Copy Markdown
Member Author

@astrofrog , any idea where is the next best place to put it without creating a new job just for it? We don't want it to miss too many tests and we know it doesn't work for oldest-deps and probably unwise to put it under Windows (not sure about OSX).

@astrofrog

astrofrog commented Nov 13, 2020

Copy link
Copy Markdown
Member

What about adding open files to the 'Python 3.8 with all optional dependencies' on Linux and measuring durations on the MacOS X and Windows equivalent ones?

@pllim
pllim force-pushed the actions-open-files branch from 8b6d259 to 3802426 Compare November 13, 2020 21:23
@pllim

pllim commented Nov 13, 2020

Copy link
Copy Markdown
Member Author

Like this, @astrofrog ?

@pllim
pllim marked this pull request as ready for review November 13, 2020 21:24
astrofrog
astrofrog approved these changes Nov 13, 2020
View reviewed changes

@astrofrog astrofrog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's fine by me :)

@pllim
pllim force-pushed the actions-open-files branch from 3802426 to 33addba Compare November 13, 2020 22:17
@pllim pllim changed the title EXP: See if --open-files runs TST: Add back --open-files to one job Nov 13, 2020
@pllim

pllim commented Nov 13, 2020

Copy link
Copy Markdown
Member Author

Gah... It uses openfiles-0.5.0 and took 1.5 hours. I thought I pinned it but apparently not. Too many actions.

@pllim
pllim force-pushed the actions-open-files branch from 33addba to ad4247d Compare November 13, 2020 22:55
@pllim
pllim merged commit 790332a into astropy:master Nov 13, 2020
@pllim
pllim deleted the actions-open-files branch November 13, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astrofrog astrofrog astrofrog approved these changes

Assignees

No one assigned

Labels

no-changelog-entry-needed testing

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

2 participants

@pllim @astrofrog