Repository navigation
TST: Allow remote data job to fail, cron org - #11036
Conversation
saimn
left a comment
saimn
left a comment
There was a problem hiding this comment.
Splitting daily and weekly builds seems a very good idea !
Do we need to have py37-test-devdeps both on the daily, weekly and normal builds?
Definitely not in both daily and weekly. I think daily and weekly should be mutually exclusive. With this patch, the devdeps runs for push (with remote data) and daily (without remote data). And the Python dev runs weekly. |
|
Right, sorry for the confusion, it's not in the weekly build, but it is twice in the normal build. Once without remote data on macos, and once with remote data in the allowed failures. |
|
Re: #11036 (comment) -- Good catch! I think it is a typo. |
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
Looks good and I like the separation into daily and weekly, but just a note about the 3.10 job.
| # Test against Python dev in cron job. | ||
| - name: Python dev with basic dependencies | ||
| os: ubuntu-latest | ||
| python: 3.9-dev |
There was a problem hiding this comment.
Since 3.9 is out what does this install? 3.10a1 is already out right so by the comment we should actually leave 3.10-dev?
I wonder if it would be more correct to set it to 3.10-dev and comment out and put a note to uncomment once Numpy supports Python 3.10?
(We should probably add a stable 3.9 job to the main matrix btw)
Actually I wonder whether it would work with 3.10-dev if we specified -devdeps in the tox env - Numpy may have fixed compatibility issues there.
There was a problem hiding this comment.
3.10a1, in my understanding, is not yet to be used, though I would agree that changing this job to 3.10-dev would make sense, but then we better to comment it out until the dev cycle is a bit further along.
There was a problem hiding this comment.
Yes, we should comment this until the beta/rc versions are available.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
TST: Split cron jobs into daily and weekly. TST: Downgrade Python dev to 3.9-dev. [ci skip]
[ci skip] Co-authored-by: Simon Conseil <[email protected]>
7dbd314 to
4d0b7da
Compare
|
I addressed your comments about python dev job. Also updated the docs. If you are okay with this, please approve. Thanks! |
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
Looks good to me! Once this is merged I'll open a PR to add arm etc to the weekly cron
Out of scope: Fixing failing cron and remote-data jobs. We can do that in separate PRs. The main goal for this PR is to allow the "fail fast" mode so we don't waste CPU cycles.
TODO:
This is a direct follow up of #10388 .