Repository navigation
TST: Skip test_update_parallel_multi on Windows CI too - #10924
Merged
Merged
Conversation
mhvk
approved these changes
Oct 22, 2020
mhvk
left a comment
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I added a note to the old issue mentioning that it fails on windows too.
mhvk
reviewed
Oct 22, 2020
| ) | ||
|
|
||
| TRAVIS = os.environ.get('TRAVIS', False) | ||
| TRAVIS = os.environ.get('TRAVIS', False) == "true" |
Contributor
There was a problem hiding this comment.
Do we need to do this in other places too?
Member
Author
There was a problem hiding this comment.
Not really, as the other places pass in a string into skipif condition but I am not.
bsipocz
approved these changes
Oct 23, 2020
Member
|
Thanks @pllim! |
bsipocz
added a commit
that referenced
this pull request
Nov 6, 2020
TST: Skip test_update_parallel_multi on Windows CI too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to skip
test_update_parallel_multion Windows CI as well. It is already skipped forpython < 3.8due to "mystery segfault" (#10008). I could not reproduce it locally (2 tries) and it is only intermittent on CI.Fixes #10914
cc @aarchiba