Repository navigation
Done reorder between conda and pip - #10919
CosmicTiger wants to merge 1 commit into
Conversation
|
Hello. Can you please clarify if this PR is to resolve an existing issue? |
|
Hello @pllim yes it is related with the issue #6154 (comment) in which @astrojuanlu mentioned the reorder between conda installation and pip that they supposed to be in that exact order as I mentioned. I did not touch anything of the default answer of the PR because it seems that is something by default of one of your files and I didn't want to messed up anything. |
|
A lot has happened in the past 3 years, so I'm not sure any more that suggesting conda first is still the desirable approach, even though the issue hasn't been triaged and closed (thanks @CosmicTiger to find it!) cc-ing @mwcraig and @taldcroft as they were involved in the xrefed issue and wrote the original comment asking for this change. |
I still think that conda is the simplest approach for typical users. In other words, I still agree with the statement: The Anaconda powershell on Windows seems very useful to me when I need to do Windows testing / development. I also think conda makes it much easier to work with different versions of Python, and in particular for users on systems with an older Python to use the latest. That said, this all reflects my own experience and I only use conda, so I might be missing developments that make everything just easily work on all platforms. |
|
This reordering is fine. These days I lean more towards miniconda + custom environments but that is probably too much for a brand new user. Anaconda is still probably the best bet for those folks. |
|
Re: Anaconda vs Miniconda I'd rather people learn how to |
mwcraig
left a comment
There was a problem hiding this comment.
Just one small change (several lines to cut 😀 , one to modify) and this is ready to go!
|
|
||
| To also be able to run tests (see below) and support :ref:`builddocs` use the | ||
| following. We use ``pip`` for these packages to ensure getting the latest | ||
| releases which are compatible with the latest ``pytest`` and ``sphinx`` releases:: |
There was a problem hiding this comment.
I think these two can now be included with the conda install command above. While there is a lag of a couple of hours between when the package is published on pypi and when it shows up in conda-forge it isn't much more than that these days. Any advantage gained by installing these with pip is outweighed, I think, by the disadvantage of having to remember which things are upgraded by pip and which by conda.
Agree! I teach new students this right away because it is so much easier to nuke an environment than your entire install. But that seems like a much bigger change than what @CosmicTiger had started. |
|
True, it is a borderline scope creep. But if we're doing the update anyway... If @CosmicTiger does not wish to make changes outside of strict re-ordering, we can follow-up after this is merge. |
astrofrog
left a comment
There was a problem hiding this comment.
I'm tempted to say we keep pip first now as pip is a lot better than it used to be and conda is a lot worse :-/ But no strong opinions, so happy to go with what others think.
This reflects my own views at the moment. But I don't know if this is because pip has objectively gotten better while conda has gotten worse, or because I have gained enough expertise to understand when should I use one or the other... I find myself having to explain PEP 518 & 517, wheels vs tarballs, and obscure |
|
Also, I should note that |
|
In terms of dependency resolution speed, my experience with conda is that it has gotten much better in most cases in the last couple of years. @astrofrog - are there problems you are aware of for the simple use cases of beginners? I agree that miniconda is definitely the way to go for slightly experienced users. So in the paragraph above I would say: If / when pip 20.3 gets released including an actual dependency solver like conda, then we'll see how many problems come up. I predict a lot of people pinning |
|
In another plug for conda, I note that we use it to manage and install Perl packages! |
|
Pinging @CosmicTiger in case they want to address @mwcraig request, although I'm not sure if we have any conclusions for the debate we had here. If we decide this is an incremental improvement in the right direction, let's move forward, otherwise I'm not sure what would be the best way to draw the current consensus about the best way to install Astropy for newcomers. |
|
We haven't heard from the original PR author in a while, and I think based on backs-and-forth about conda, we are not in a hurry to make this change, right? |
|
I would vote to just merge this as is, invoking the "perfect is the enemy of good" mantra. This PR accomplishes the simple goal of re-ordering the sections and it closes an issue! We can come back to fixing the niggles later as needed. Although there are outstanding differences of opinion on the conda vs. pip question, it is worth noting that numpy recommends conda for both beginning and advanced users (https://numpy.org/install/). For me it is a good thing to coalesce on a common recommendation. And maybe it isn't a coincidence, but same for SciPy: https://scipy.org/install.html#scientific-python-distributions-recommended. Pandas shows conda first as well. The only big hitter that shows |
|
Hi humans 👋 - this issue was labeled as Close? approximately 2 months ago. If you think this issue should not be closed, a maintainer should remove the Close? label - otherwise, I will close this issue in 7 days. If you believe I commented on this issue incorrectly, please report this here |
|
Ops... supposed to run for issues only. Please ignore, sorry. |
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 10 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
|
I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks! If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here. |
|
I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks! If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here. |
Description
This pull request is to address ...
EDIT: Fixes #6154