Skip to content

Fix table sorting for a single Time column - #10824

Merged
taldcroft merged 2 commits into
astropy:masterfrom
mhvk:table-argsort-time
Oct 17, 2020
Merged

taldcroft merged 2 commits into
astropy:masterfrom
mhvk:table-argsort-time

Conversation

@mhvk

@mhvk mhvk commented Oct 9, 2020

Copy link
Copy Markdown
Contributor

fixes #10823

Sorting on a single time column worked in 4.0, but is broken in 4.1-rc2. I milestoned 4.1.1, but perhaps it can still make it for 4.1.

@mhvk mhvk added this to the v4.1.1 milestone Oct 9, 2020
@mhvk
mhvk requested a review from taldcroft October 9, 2020 21:06

@taldcroft taldcroft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@taldcroft
taldcroft merged commit 73973e9 into astropy:master Oct 17, 2020
@mhvk
mhvk deleted the table-argsort-time branch October 17, 2020 14:47
eteq pushed a commit to eteq/astropy that referenced this pull request Oct 19, 2020
Fix table sorting for a single Time column
eteq pushed a commit that referenced this pull request Oct 19, 2020
Fix table sorting for a single Time column
@bsipocz bsipocz modified the milestones: v4.1.1, v4.2, v4.1 Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot sort table by Time column

3 participants