Skip to content

Improve and simplify handling of parameters - #1075

Merged
nden merged 1 commit into
astropy:masterfrom
nden:parameters_update
May 9, 2013
Merged

Improve and simplify handling of parameters#1075
nden merged 1 commit into
astropy:masterfrom
nden:parameters_update

Conversation

@nden

@nden nden commented May 9, 2013

Copy link
Copy Markdown
Contributor
  • Allow a parameter of type array
  • Allow models to have parameters of mixed type, e.g. a number and an array
  • Add some validation for multiple parameter sets
  • Allow Gaussian models to have multiple parameter sets

This supersedes #1051.

@nden nden mentioned this pull request May 9, 2013
Closed
@eteq

eteq commented May 9, 2013

Copy link
Copy Markdown
Member

@nden - to answer your question from #1051 : I usually just give these sorts of things ~1 day, as someone might be inclined to look over it just to double-check the fixes. But assumng the travis tests pass, I'd say it's fine to just merge it after that if you don't get any comments.

@eteq eteq mentioned this pull request May 9, 2013
Merged
nden added a commit that referenced this pull request May 9, 2013
@nden
Merge pull request #1075 from nden/parameters_update
8871266 
Improve and simplify handling of parameters
@nden
nden merged commit 8871266 into astropy:master May 9, 2013
@embray embray mentioned this pull request May 9, 2013
Closed
@nden nden mentioned this pull request May 9, 2013
Closed
@nden
nden deleted the parameters_update branch April 30, 2018 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nden @eteq