Skip to content

Edits in documentation - #10722

Merged
pllim merged 6 commits into
astropy:masterfrom
migueldvb:docs
Sep 10, 2020
Merged

pllim merged 6 commits into
astropy:masterfrom
migueldvb:docs

Conversation

@migueldvb

Copy link
Copy Markdown
Member

Description

This pull request includes some updates in the development documentation and a few minor corrections.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, good catch. Thanks!

@pllim pllim added this to the v4.0.2 milestone Sep 10, 2020
@pllim

pllim commented Sep 10, 2020

Copy link
Copy Markdown
Member

This warning might be related and should be fixed before merge:

.../docs/index.rst:17: WARNING: Duplicate explicit target name: "affiliated packages".

@migueldvb

Copy link
Copy Markdown
Member Author

.../docs/index.rst:17: WARNING: Duplicate explicit target name: "affiliated packages".

Ah! it was introduced in this PR. I think it should be fixed now.

Comment thread docs/index.rst Outdated
* :ref:`search`

.. [email protected]: mailto:[email protected]
.. _affiliated packages: http://www.astropy.org/affiliated/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You HTTPS-ed everything else, why not here too? 😉

Suggested change
.. _affiliated packages: http://www.astropy.org/affiliated/
.. _affiliated packages: https://www.astropy.org/affiliated/

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right! I amended the last commit.

.../docs/index.rst:17: WARNING: Duplicate explicit target name: "affiliated packages".

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks!

@pllim
pllim merged commit aeabab1 into astropy:master Sep 10, 2020
astrofrog pushed a commit that referenced this pull request Oct 6, 2020
astrofrog pushed a commit that referenced this pull request Oct 6, 2020
eteq pushed a commit to eteq/astropy that referenced this pull request Oct 12, 2020
eteq pushed a commit that referenced this pull request Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants