MNT: Replace distutils with setuptools in wcs extension test#10581
Merged
embray merged 2 commits intoastropy:mainfrom Jun 29, 2021
Merged
MNT: Replace distutils with setuptools in wcs extension test#10581embray merged 2 commits intoastropy:mainfrom
embray merged 2 commits intoastropy:mainfrom
Conversation
Member
|
I'll take a look at it. Weird that this would fail. |
It still calls setup.py directly, but with the right flags needed by setuptools to invoke "distutils-like" installation, rather than setuptools' legacy default behavior of building and installing an EGG. In the future we might want to change this to a more "modern" Python package and build/install with pip, though for building extension modules with setuptools, writing a setup.py is still the best way. Also removed the awkward bit where the astropy path was passed to setup.py as an extra command-line argument. Setting PYTHONPATH is good-enough for this.
694cae9 to
d2cf590
Compare
Member
|
@pllim I updated your PR: It should be working now. |
pllim
commented
Jun 21, 2021
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This has been resolved.
This will fail. Not sure how to fix.
This is a direct follow-up of #10571 .