MNT: Replace distutils.log with astropy logger#10580
Merged
bsipocz merged 1 commit intoastropy:masterfrom Oct 23, 2020
Merged
Conversation
Member
Author
|
Remote failures unrelated. |
mhvk
approved these changes
Jul 17, 2020
Contributor
mhvk
left a comment
mhvk
left a comment
There was a problem hiding this comment.
Ha, I had forgotten we had our own. This seems trivially OK, but perhaps @astrofrog (who added the log.info messages) can check, just to be sure.
bsipocz
approved these changes
Oct 23, 2020
Member
|
Thanks @pllim! |
bsipocz
added a commit
that referenced
this pull request
Nov 6, 2020
MNT: Replace distutils.log with astropy logger
Member
|
@bsipocz This is what is causing the CI to fail in LTS since it means the testing command needs astropy to be installed, which it isn't when |
Member
Author
|
I am sorry...
|
dhomeier
pushed a commit
to dhomeier/astropy
that referenced
this pull request
Nov 11, 2020
MNT: Replace distutils.log with astropy logger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to replace the use of
distutils.logwith our own logger.This is a direct follow-up of #10571 .