Skip to content

TST: Fix Sphinx warning for test runner - #10477

Merged
mhvk merged 1 commit into
astropy:masterfrom
pllim:fix-doc-build
Jun 9, 2020
Merged

mhvk merged 1 commit into
astropy:masterfrom
pllim:fix-doc-build

Conversation

@pllim

@pllim pllim commented Jun 9, 2020

Copy link
Copy Markdown
Member

Description

This pull request is to address Sphinx warning that started showing up when generating automodapi for astropy.tests.runner.

Fixes #10473

@pllim

pllim commented Jun 9, 2020

Copy link
Copy Markdown
Member Author

Maybe the correct fix is really to make sphinx-automodapi be compatible with Sphinx 3.1.0 but I don't have time to do that. This will have to do for now, so PRs CI don't get blocked.

@pllim

pllim commented Jun 9, 2020

Copy link
Copy Markdown
Member Author

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal, but we do need a fix, so I'm going to approve and merge!
Could you raise a new issue to clean this up? From what you write, it sounds it may be an "upstream fix required" one....

@mhvk
mhvk merged commit 435eeec into astropy:master Jun 9, 2020
@pllim
pllim deleted the fix-doc-build branch June 9, 2020 20:50
@pllim

pllim commented Jun 9, 2020

Copy link
Copy Markdown
Member Author

Thanks, @mhvk ! Follow-up issue is at #10478

@mhvk

mhvk commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

Thanks!

pllim added a commit to pllim/astropy that referenced this pull request Jan 25, 2023
to see if sphinx-automodapi is now compatible with Sphinx
dougbrn pushed a commit to dougbrn/astropy that referenced this pull request Mar 13, 2023
to see if sphinx-automodapi is now compatible with Sphinx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: html-docs job failing on CircleCI

2 participants