Repository navigation
Raise TypeError when scalar column added to empty table - #10476
Merged
Merged
Conversation
pllim
reviewed
Jun 9, 2020
pllim
added
the
API change
taldcroft
reviewed
Jun 11, 2020
taldcroft
changed the title
Member
|
@gregosimo - looks generally good, thanks! I made a few tiny tweaks. |
Member
|
I see now that the changelog entry is in the wrong section. It is currently in 4.0.1 but should be in 4.2. |
Co-authored-by: P. L. Lim <[email protected]>
bsipocz
added
the
zzz 💤 merge-when-ci-passes
bsipocz
approved these changes
Oct 23, 2020
bsipocz
left a comment
bsipocz
left a comment
Member
There was a problem hiding this comment.
I take the discussion as an approval from the package maintainer, so let's just get this merged now.
Member
|
Thank you @gregosimo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address the uninformative error message when a column in an empty table is assigned to a scalar. Now assigning a column in an empty table to a scalar will result in an TypeError at assignment with a relevant error message, rather than a TypeError on access with a more opaque error message.
Fixes #3811