Repository navigation
Split setup.cfg test and all into types; use in tox.ini - #10464
Conversation
There was a problem hiding this comment.
If this can wait, I would like input from @astrofrog when he is available. Maybe @Cadair wants to look too since he has dealt with packaging for Sunpy etc.
If we decide to move forward with this, install.rst and maybe even the dev docs also need to be updated to instruct people how this is intended to be used.
Thank you!
|
Hello. I converted your PR to a draft PR due to #10706 . |
4ddaef7 to
2b239d4
Compare
|
This looks straightforward to me. Any help needed finishing this up? I agree with @pllim it should be mentioned in the installation docs. |
1 similar comment
2b239d4 to
261b1a4
Compare
|
OK, I tried to find places where it would be good to mention the changes. Please let me know of any others! |
|
@pllim Any final thoughts on this one, or should we merge? |
|
I'll have a look soon. Thanks for your patience! |
|
Pretty sure the failure was fixed in #11858 but since this PR touches on dependencies, I would like to request a rebase, just to make sure. Thanks! |
|
I guess repetitions are unavoidable and seems like the benefits outweigh the costs here. We can worry about testing the new "recommended" deps in CI if the need arises in the future. I think we already have enough jobs as it is. I'll approve after rebase is done (please ping me). 😸 |
261b1a4 to
f2ede45
Compare
|
@pllim - no problem, rebased! |
As a start to address #10342. Two commits just to have something concrete to discuss.
testdependencies into those that are needed to do the testing, and a newtest_allthat includes packages used for comparison purposes.recset of recommended packages fromall; the objective criterion is that these are all listed as "key" dependencies indevdeps- though they also happen to match more or less what I would pick.p.s. Cancelled all tests, though checked locally that things work. Can adapt
.travis.ymlif we find there is a use for it.