Skip to content

Check values equal to zero in QuantityAttribute a bit more carefully. - #10432

Merged
adrn merged 1 commit into
astropy:masterfrom
mhvk:coord-quantity-attribute-numpy-dev-deprecation
Jun 3, 2020
Merged

adrn merged 1 commit into
astropy:masterfrom
mhvk:coord-quantity-attribute-numpy-dev-deprecation

Conversation

@mhvk

@mhvk mhvk commented Jun 2, 2020 •

Copy link
Copy Markdown
Contributor

In the process resolving a bug that we tried to create an array with shape=None, which is being deprecated, which is causing failures on the numpy-dev runs.

In the process resolving a bug that we tried to create an array with
shape=None, which is being deprecated.
@mhvk

mhvk commented Jun 2, 2020

Copy link
Copy Markdown
Contributor Author

numpy-dev job passed.

@adrn adrn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrn
adrn merged commit 6054cc7 into astropy:master Jun 3, 2020
@mhvk
mhvk deleted the coord-quantity-attribute-numpy-dev-deprecation branch June 3, 2020 13:20
astrofrog pushed a commit that referenced this pull request Jun 5, 2020
…v-deprecation

Check values equal to zero in QuantityAttribute a bit more carefully.
astrofrog pushed a commit that referenced this pull request Jun 5, 2020
…v-deprecation

Check values equal to zero in QuantityAttribute a bit more carefully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants