Repository navigation
Add optimize flag in yacc.yacc calls to allow importing units under python -OO - #10379
Merged
Merged
Conversation
Co-authored-by: Marten van Kerkwijk <[email protected]>
Contributor
|
If I understand correctly, what this really changes is how the tables are interpreted, so it should be OK. Given that we already had it on part, I think it should be fine (and should improve startup too). I don't really want to count this as a bug-fix, though - I don't feel we guaranteed that one could run with Could you add a changelog entry under other changes and additions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Marten van Kerkwijk [email protected]
Description
Fixes #10361 – tested as described in #10361 (comment) and with
python setup.py -O2.Changed the call in
angle_utilities.pyas a cautionary measure, although I could not create a similar failure on importingcoordinates.No idea for a genuine test of the original issue, so I am putting this up as is for discussion.