Skip to content

Update built-in IERS files - #10376

Merged
mhvk merged 2 commits into
astropy:masterfrom
astrofrog:update-iers
May 21, 2020
Merged

mhvk merged 2 commits into
astropy:masterfrom
astrofrog:update-iers

Conversation

@astrofrog

Copy link
Copy Markdown
Member

This updates the built-in IERS files using the update_builtin_iers.sh files. I'm not sure why the diff is so large, will try and investigate later today.

@astrofrog

Copy link
Copy Markdown
Member Author

@mhvk - there is a real doctest failure now:

______________________________ [doctest] iers.rst ______________________________

155 In most cases the automatic interface will suffice, but you may need to

156 directly load and manipulate IERS tables.  IERS-B values are provided as part

157 of astropy and can be used to calculate time offsets and polar motion

158 directly, or set up for internal use in further time and coordinate

159 transformations.  For example::

160 

161   >>> from astropy.utils import iers

162   >>> t = Time('2010:001')

163   >>> iers_b = iers.IERS_B.open()

164   >>> iers_b.ut1_utc(t)  # doctest: +FLOAT_CMP

Expected:

    <Quantity 0.1140827 s>

Got:

    <Quantity 0.114033 s>

/home/travis/build/astropy/astropy/docs/utils/iers.rst:164: DocTestFailure

Could you take a look to see what might be going on? I just used the update_builtin_iers.sh script to update the files

@mhvk

mhvk commented May 20, 2020

Copy link
Copy Markdown
Contributor

@astrofrog - the IERS B files seem a lot less "permanent" than one would think. I certainly have seen similarly large ranges of it changed by small amounts, presumably due to a reanalysis or so. Since that really is not under our control, my sense would be to simply adjust the doctest...

@astrofrog

Copy link
Copy Markdown
Member Author

@mhvk - ok thanks!

# leap second was introduced since the corresponding date
# Updated through IERS Bulletin 59 issued in January 2020
#
#

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the added whitespace is not ideal, but maybe best to just bundle it exactly as it is provided...

@astrofrog

Copy link
Copy Markdown
Member Author

@mhvk - could you review/approve this? (one of the last things that needs to be included for the 4.1 release)

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, yes, approved! And merging too. Thanks!

@mhvk
mhvk merged commit 7cf9b9b into astropy:master May 21, 2020
@astrofrog

Copy link
Copy Markdown
Member Author

@mhvk - thanks! Just to check, we should update this file in bugfix releases e.g. for the LTS version too, right?

astrofrog pushed a commit that referenced this pull request May 22, 2020
@pllim

pllim commented May 22, 2020 •

Copy link
Copy Markdown
Member

Wait a minute. Remote data job failed. See #10386

@astrofrog astrofrog mentioned this pull request May 23, 2020
17 of 19 tasks
@mhvk

mhvk commented May 23, 2020

Copy link
Copy Markdown
Contributor

Yes, LTS should be updated too. I've seen the discussion about the failure but am so far failing to understand. Hope to check later.

@astrofrog astrofrog modified the milestones: v4.1, v4.0.2 May 24, 2020
astrofrog pushed a commit that referenced this pull request May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants