Repository navigation
Fix codestyle checks in tox and fix PEP8 whitespace issues - #10347
Merged
Merged
Conversation
astropy-bot
Bot
added
coordinates
io.ascii
io.misc
zzz 💤 io.misc.asdf
astrofrog
added
the
Affects-dev
Member
|
Well, hopefully this would fix the Travis CI job too. Thanks! |
Member
|
p.s. LoL, look at all those labels. |
astrofrog
added
the
zzz 💤 merge-when-ci-passes
Member
Author
|
OH MY GOD IT'S FULL OF LABELS! |
astrofrog
pushed a commit
that referenced
this pull request
May 19, 2020
Fix codestyle checks in tox and fix PEP8 whitespace issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tox
codestyleenvironment was actually not running in the correct directory (sorry 😨) so this PR fixes this and PEP8 issues that have crept in in the mean time. A new release of flake8 this weeks means we actually got an error because of the wrong directory, whereas before it was silently 'failing'. This should fix the CircleCI html-docs job which was failing because of this.EDIT: Fix #10348