Skip to content

BUG: Fix wcsapi doctest - #10301

Merged
Cadair merged 1 commit into
astropy:masterfrom
pllim:wcsapi-remote-test
May 5, 2020
Merged

Cadair merged 1 commit into
astropy:masterfrom
pllim:wcsapi-remote-test

Conversation

@pllim

@pllim pllim commented May 4, 2020

Copy link
Copy Markdown
Member

Description

This pull request is to address failing remote data doctest for wcsapi example. I think this is a direct follow-up of #10229.

Fixes #10299

@pllim pllim added testing Docs Bug Affects-dev PRs and issues that do not impact an existing Astropy release wcs.wcsapi labels May 4, 2020
@pllim pllim added this to the v4.1 milestone May 4, 2020
@pllim
pllim requested a review from Cadair May 4, 2020 19:07
@astropy-bot astropy-bot Bot added the wcs label May 4, 2020
@pllim

pllim commented May 5, 2020

Copy link
Copy Markdown
Member Author

wcsapi doctest failure is gone with this patch. Other remote data failures are unrelated.

@Cadair
Cadair merged commit 6c476ed into astropy:master May 5, 2020
@Cadair

Cadair commented May 5, 2020

Copy link
Copy Markdown
Member

How did that sneak past?

@pllim
pllim deleted the wcsapi-remote-test branch May 5, 2020 14:32
@pllim

pllim commented May 5, 2020

Copy link
Copy Markdown
Member Author

How did that sneak past?

Quite easily, as it was buried between a bunch of unrelated EarthLocation failures.

@Cadair

Cadair commented May 5, 2020

Copy link
Copy Markdown
Member

🙈

astrofrog pushed a commit that referenced this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Bug Docs testing wcs.wcsapi wcs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: wcsapi.rst failed remote data doctest

2 participants