Skip to content

MNT: Make matplotlib import truly optional in image_tests.py - #10259

Merged
bsipocz merged 1 commit into
astropy:masterfrom
pllim:optional-import-matplotlib
May 1, 2020
Merged

MNT: Make matplotlib import truly optional in image_tests.py#10259
bsipocz merged 1 commit into
astropy:masterfrom
pllim:optional-import-matplotlib

Conversation

@pllim

@pllim pllim commented May 1, 2020

Copy link
Copy Markdown
Member

Description

This pull request is to address matplotlib import error mentioned in #10246 .

____________________________________ ERROR collecting astropy/tests/image_tests.py _____________________________________
astropy/tests/image_tests.py:1: in <module>
    import matplotlib
E   ModuleNotFoundError: No module named 'matplotlib'

Given today is feature freeze day, I'll let someone else milestone this.

@pllim
pllim requested review from astrofrog and bsipocz May 1, 2020 21:32
@pllim pllim mentioned this pull request May 1, 2020
Open
@bsipocz bsipocz added this to the v4.0.2 milestone May 1, 2020
@bsipocz
bsipocz merged commit 902f594 into astropy:master May 1, 2020
@bsipocz

bsipocz commented May 1, 2020

Copy link
Copy Markdown
Member

Thanks @pllim!

@pllim
pllim deleted the optional-import-matplotlib branch May 2, 2020 00:16
astrofrog pushed a commit that referenced this pull request May 19, 2020
@bsipocz @astrofrog
Merge pull request #10259 from pllim/optional-import-matplotlib
b9a4e84 
MNT: Make matplotlib import truly optional in image_tests.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsipocz bsipocz bsipocz approved these changes
@astrofrog astrofrog Awaiting requested review from astrofrog

Assignees

No one assigned

Labels

no-changelog-entry-needed testing visualization

Projects

None yet

Milestone

v4.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@pllim @bsipocz