Repository navigation
Tidy up SlicedLowLevelWCS to facilitate more development - #10229
Conversation
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
Looks good to me - it would be good for @nden or @perrygreenfield to take a look at this too, but since this is just internal refactoring, it can be merged later today if no objections.
|
Bit less confident here, but removing milestone as it would seem that one can develop against master and that, therefore, this is not release-critical for 4.1. |
Also move the array_index-related methods to the base classes since they can be effectively be the same for all implementations
|
I appreciate I didn't get this one across the line so if it slips I will live with it, but a word for its inclusion in 4.1. This PR came out of #9736 and discussions with interested people around it. The idea is for us to bundle the contents of #9736 in the upcoming release of ndcube, to give them some time out in the wild and see how well they work. Therefore, I would really like this in 4.1 so that NDCube 2.0 can depend upon 4.1 and make my life a whole lot easier. Also the contents of this PR is mostly refactoring and docstring improvements at this point, it's just a nice no API change cleanup PR. |
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
@nden's comments have been addressed, so I think this is good to go. This is only really internal code reorganization from a public API point of view (and no new features), so I'm happy to merge this even though the feature freeze deadline has passed.
|
Did this break a test? See #10299 |
Following discussion with @nden, @astrofrog and @perrygreenfield we decided that #9736 requires more time in the oven (and experimentation outside of core) so that development will likely move to ndcube for the next dev cycle or two.
Therefore, this replaces #9736 for 4.1 and is to facilitate further development of those classes outside of core.
This does the following main things:
SlicedLowLevelWCStowrappers/sliced_wcs.pyBaseWrapperclass, to reduce duplication of APE 14 wrappers.array_index_to_world_valuesandworld_to_array_index_valuestoBaseLowLevelWCSas they can be implemented based on thepixel_versions.