Skip to content

Add TimeUnixTai (unix_tai) time format class - #10081

Merged
mhvk merged 4 commits into
astropy:masterfrom
taldcroft:time-unix-tai
Mar 31, 2020
Merged

Add TimeUnixTai (unix_tai) time format class#10081
mhvk merged 4 commits into
astropy:masterfrom
taldcroft:time-unix-tai

Conversation

@taldcroft

@taldcroft taldcroft commented Mar 29, 2020

Copy link
Copy Markdown
Member

Description

This PR adds a new time format unix_tai which is roughly Unix time (unix format) but with leap seconds included.

Closes #10052

@taldcroft taldcroft added the time label Mar 29, 2020
@taldcroft taldcroft added this to the v4.1 milestone Mar 29, 2020
@taldcroft taldcroft mentioned this pull request Mar 29, 2020
Closed
@morcuended morcuended mentioned this pull request Mar 29, 2020
Closed
mhvk
mhvk approved these changes Mar 29, 2020
View reviewed changes

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way it is quite simple, which is nice. The failures seem to be due to doctests which list the formats, where unix_tai needs to be added.

@pllim

pllim commented Mar 29, 2020

Copy link
Copy Markdown
Member

Does this need a what's new entry?

@mhvk

mhvk commented Mar 30, 2020

Copy link
Copy Markdown
Contributor

Still a relevant error from the circle-ci docs build:
/home/circleci/project/.tox/build_docs/lib/python3.7/site-packages/astropy/time/formats.py:docstring of astropy.time.TimeUnixTai:16:py:obj reference target not found: unix

@taldcroft

taldcroft commented Mar 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

I'm not yet feeling the joy of APE-17 and tox. Trying to build docs locally:

(astropy) ➜  astropy git:(time-unix-tai) tox -e build_docs
...
Reading sources... [100%] whatsnew/index


Warning, treated as error:
/Users/aldcroft/git/astropy/docs/units/index.rst.rst:402:autosummary: stub file not found 'astropy.units.function.logarithmic.m_bol'. Check your autosummary_generate setting.
ERROR: InvocationError for command /Users/aldcroft/git/astropy/.tox/build_docs/bin/sphinx-build -W -b html . _build/html (exited with code 2)
_____________________________________________________________________ summary _____________________________________________________________________
ERROR:   build_docs: commands failed

In particular I can't reproduce the warning/error that Travis is finding and get something that seems unrelated.

pllim
pllim reviewed Mar 30, 2020
View reviewed changes
Comment thread astropy/time/formats.py Resolved
@taldcroft

taldcroft commented Mar 30, 2020

Copy link
Copy Markdown
Member Author

Thanks @pllim !

@saimn

saimn commented Mar 30, 2020

Copy link
Copy Markdown
Contributor

@taldcroft - About the 'astropy.units.function.logarithmic.m_bol' warning, remember #10026 ;)

@taldcroft @pllim
Fix sphinx errors
ba3fc8a 
Co-Authored-By: P. L. Lim <[email protected]>
@mhvk

mhvk commented Mar 31, 2020

Copy link
Copy Markdown
Contributor

Great, tests now all pass, so merging! Thanks, @taldcroft for implementing, and @r-owen for alerting us to the need to have it

@mhvk
mhvk merged commit b539922 into astropy:master Mar 31, 2020
@r-owen

r-owen commented Mar 31, 2020

Copy link
Copy Markdown

Thank you @taldcroft and @mhvk for implementing this.

@taldcroft taldcroft mentioned this pull request Jan 13, 2021
Closed
@maxnoe maxnoe mentioned this pull request Jan 14, 2021
Merged
@ReinhardPrix ReinhardPrix mentioned this pull request Oct 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim left review comments
@mhvk mhvk mhvk approved these changes

Assignees

No one assigned

Labels

time whatsnew-needed

Projects

None yet

Milestone

v4.1

Development

Successfully merging this pull request may close these issues.

Please support TAI time expressed as unix seconds

5 participants

@taldcroft @pllim @mhvk @saimn @r-owen