Repository navigation
Conversation
Member
|
If we want to fix globally we should get astropy/ci-helpers#429 in :) Otherwise I think this is the correct fix since astropy as is currently is not compatible with pytest 5.4. I had even anticipated such a case in my ci-helpers PR: https://github.com/astropy/ci-helpers/pull/429/files#diff-6d423896b1a26291e2f62e909d184c1fR50 😆 |
This was referenced Mar 13, 2020
Member
|
I have #10044 for 4.1 that applies the tox command thingy, while this patch here can be applied directly to 4.0.x branch without going in |
Member
Author
|
4.0.x should be fine, as there is already the limitation in ci-helpers (and that branch doesn't use tox yet). |
Member
|
Working on the centralized tox script approach now. |
Member
Author
|
Thanks @astrofrog! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feels so bad on so many levels.
@astrofrog @Cadair - is hacking the packaging files is the way to limit version now, or could it go into the tox config?