Repository navigation
Warnings about cfitsio compilation flags #9625
Description
I'm seeing lots of warnings like:
warning: unknown warning option '-Wno-misleading-indentation'; did you mean '-Wno-binding-in-condition'? [-Wunknown-warning-option]
warning: unknown warning option '-Wno-format-overflow'; did you mean '-Wno-shift-overflow'? [-Wunknown-warning-option]
when compiling astropy - these occur when compiling cfitsio files. According to:
astropy/astropy/io/fits/setup_package.py
Line 45 in b8d29ba
These are meant to be to prevent cfitsio warnings, but ironically the fact these flags are not recognized by my compiler causes a lot of warnings... My compiler here is:
% clang --version
Apple clang version 11.0.0 (clang-1100.0.33.12)
Target: x86_64-apple-darwin19.0.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
@mhvk - any idea how we could avoid these warnings? (since you added the flags)
Activity
pllim commentedon Nov 19, 2019
I am gonna ping @jhunkeler too since he had dealt with such things for HSTCAL.
mhvk commentedon Nov 19, 2019
That's a long time ago - did I really do that?! But looking at the file, a bit above it, I see a clause
So I think one could similarly split up the addition of compilation flags in
clangandgccspecific sections.