Skip to content

Review test coverage #9433

Open
Open

Description

@tomdonaldson

Description

While working on issue #8995 I wondered whether there is sufficient test coverage for the binary (FITS, BINARY and BINARY2) serializations. The non-binary serialization (TABLEDATA) tests seem to have good coverage. I would like to look at whether those tests should be replicated for the binary cases, or whether the existing tests of the converters are sufficient to show that the various data types and shapes (array values) are being handled consistently across the different serializations.

In addition, PR #9505 made it clear that we could be more complete in covering the subtle aspects of VOTable format and semantics. This is important because some aspects of the VOTable spec are subject to interpretation, and more test cases could demonstrate the understanding or assumptions that were made in the implementation.

Additional context

This was inspired by #8995 and may be related to #8737.

Activity

  1. self-assigned this
    on Oct 22, 2019
  2. changed the title [-]Review test coverage for VOTable binary serializations[/-] [+]Review test coverage[/+] on Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions