Skip to content

IERS TestIERS_A class is not automatically run #9232

Closed

Description

@mhvk

The astropy.utils.tests.test_iers.TestIERS_A is run only if the directory holds an finals2000A.all file, which will never be the case in a CI run. The tests there should be merged with an IERS_Auto tests in which the file is actually downloaded.

EDIT: there are also a few tests in time/tests/test_ut1.py that do the same check.

Activity

  1. aarchiba commented on Sep 15, 2019

    @aarchiba
    Contributor

    Does it need a specific finals2000A.all file or will any old one do? If the latter just using download_file(IERS_A_URL, cache=True) as the filename will have the desired effect (download just once in the first test that needs it). (Leaving aside the tests that wipe the download cache.)

  2. mhvk commented on Sep 15, 2019

    @mhvk
    ContributorAuthor

    Any one will do, really, so I think you're right that one might as well use the downloaded version (it gets downloaded in other tests anyway).

    p.s. And, yes, we definitely need to think more about the cache!

  3. mhvk commented on Nov 29, 2024

    @mhvk
    ContributorAuthor

    All tests are run these days, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions