You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
TST: Tests failed with Numpy DeprecationWarning about np.broadcast_arrays #8935
DeprecationWarning: Numpy has detected that you (may be) writing to an array with
overlapping memory from np.broadcast_arrays. If this is intentional
set the WRITEABLE flag True or make a copy immediately before writing.
@pllim - this warning was meant to show only when we are actually trying to write to a broadcast array - which we should never do. So, I think we should only look at the actual cases where the warning is given.
From the log file, it looks like there is only a single problem somewhere in the LombScargle implementation, which we probably can fix by looking carefully at that code.
There are also some from BLS too. Unfortunately, I won't have time to investigate further for now. Someone familiar with the timeseries stuff feel free to take a stab. 🙏
Activity
mhvk commentedon Jun 29, 2019
@pllim - this warning was meant to show only when we are actually trying to write to a broadcast array - which we should never do. So, I think we should only look at the actual cases where the warning is given.
From the log file, it looks like there is only a single problem somewhere in the
LombScargleimplementation, which we probably can fix by looking carefully at that code.pllim commentedon Jun 29, 2019
There are also some from BLS too. Unfortunately, I won't have time to investigate further for now. Someone familiar with the
timeseriesstuff feel free to take a stab. 🙏bsipocz commentedon Jun 29, 2019
I'll try to find some time looking into those this weekend.
mhvk commentedon Jul 7, 2019
Looking into this more, I've concluded it is really an upstream issue: numpy/numpy#13929
mhvk commentedon Jul 7, 2019
See #8965 for an alternative solution that explicitly marks arrays as
read-onlypllim commentedon Jul 25, 2019
Fixed, thanks to @mhvk !