TST: image-tests-mpldev is failing #8678

Activity

1. pllim

   added

   testing

   on May 8, 2019
2. pllim commented on May 9, 2019

   

   pllim

   on May 9, 2019

   MemberAuthor

   More actions

   I also posted at matplotlib/matplotlib#14180 . Maybe disabling image size comparison in the test (if possible) is the best route to go.
3. pllim

   added

   visualization.wcsaxes

   on May 11, 2019
4. astrofrog commented on May 11, 2019

   

   astrofrog

   on May 11, 2019

   Member

   More actions

   We shouldn't disable the image size comparison, as this should definitely count as a failure. The current output is currently wrong, either due to a bug in Matplotlib or a change in API in Matplotlib, so we need to address the underlying cause either way.

   For example, test_patches_distortion has:

   Before:

   

   After:

   

   I'm currently bisecting Matplotlib to understand why this changed (and is now wrong)
5. astrofrog commented on May 11, 2019

   

   astrofrog

   on May 11, 2019

   Last edited by astrofrog

   Member

   More actions

   Bisecting points to matplotlib/matplotlib#14134 as the culprit. I'll try and understand if this is an actual bug in MPL or whether we need to fix anything in WCSAxes.
6. astrofrog commented on May 11, 2019

   

   astrofrog

   on May 11, 2019

   Member

   More actions

   A minimal example that demonstrates the issue is:

   from astropy.wcs import WCS
   import matplotlib.pyplot as plt
   
   wcs = WCS()
   fig = plt.figure(figsize=(3, 3))
   ax = fig.add_axes([0.25, 0.25, 0.5, 0.5], projection=wcs, aspect='equal')
   ax.set_xlim(0, 10000)
   ax.set_ylim(0, 10)
   fig.savefig('test.png', bbox_inches='tight')

   this seems to happen only when aspect='equal'. I'll investigate further.
7. astrofrog commented on May 11, 2019

   

   astrofrog

   on May 11, 2019

   Member

   More actions

   I've posted a comment here in case there are any insights on the Matplotlib side.
8. astrofrog commented on May 11, 2019

   

   astrofrog

   on May 11, 2019

   Member

   More actions

   And I've now narrowed this down to a minimal example in matplotlib/matplotlib#14134 (comment), so let's see what they say.

   👍React with 👍1Reacted by P. L. Lim
9. pllim commented on May 15, 2019

   

   pllim

   on May 15, 2019

   MemberAuthor

   More actions

   mpldev job is failing now with a different error:

   ! LaTeX Error: File `type1ec.sty' not found.
   

   https://circleci.com/gh/astropy/astropy/31251
10. astrofrog commented on May 15, 2019

    

    astrofrog

    on May 15, 2019

    Member

    More actions

    Whaaaaaat

    👍React with 👍1Reacted by Thomas Robitaille

    😄React with 😄1Reacted by P. L. Lim
11. astrofrog commented on May 17, 2019

    

    astrofrog

    on May 17, 2019

    Member

    More actions

    See matplotlib/matplotlib#14151 - PR forthcoming
12. pllim commented on May 17, 2019

    

    pllim

    on May 17, 2019

    MemberAuthor

    More actions

    Thanks, @astrofrog ! #8722 did indeed fix sty not found error, but we still have the xfail-ed ones to deal with whenever you can get to it (no rush currently unless they are released that version soon).
13. astrofrog commented on May 17, 2019

    

    astrofrog

    on May 17, 2019

    Member

    More actions

    The xfailed ones will be fixed by matplotlib/matplotlib#14216 :)

    🎉React with 🎉2Reacted by P. L. Lim and Brigitta Sipőcz
14. bsipocz

    closed this as completedin #8757on May 24, 2019