Skip to content

Make it possible to use NDDataArray as a mix-in column in tables #8159

New issue
New issue
Open
Open
Make it possible to use NDDataArray as a mix-in column in tables#8159
Labels
Feature Requestnddatatable

Description

@astrofrog
astrofrog
opened on Nov 19, 2018

It would be nice to have the ability to use NDDataArray objects as mix-in columns in table.

See astropy/astropy-APEs#12 (comment) for a discussion that motivated this.

Activity

  1. astrofrog
    added
    Feature Request
    table
    nddata
    on Nov 19, 2018

  2. taldcroft commented on Dec 7, 2018

    @taldcroft
    taldcroft
    on Dec 7, 2018
    Member

    See WIP #8226. The catch here is that it is necessary to override __getitem__ in order to propagate info correctly (e.g. in the case of slicing). Having a pure-Python __getitem__ is no good because it kills performance in a big way. For Table this was solved with a Cython mixin class:
    https://github.com/astropy/astropy/blob/master/astropy/table/_column_mixins.pyx

    Maybe this would work for NDData?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Feature Requestnddatatable

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions