Repository navigation
wcs method names are confusing #815
Description
As @adrn pointed out in #812, the method names on the WCS object are less than ideal, though I should point out they are a significant improvement over the wcslib names, e.g. p2s, s2p etc.
I think the best solution is to probably have pix_to_world and world_to_pix with keyword args to control which of the transformations are performed (defaulting to all) and then we would deprecate the existing methods.
Activity
astrofrog commentedon Feb 25, 2013
👍
eteq commentedon Feb 26, 2013
👍 in principal, although I would think this would be part of the (admittedly pie-in-the-sky right now) future "generalized WCS"? Or do we want to slowly incorporate that into the existing
WCS?mdboom commentedon Feb 26, 2013
I think in the end, the generalized WCS will call into this as a backend -- I don't think there's much point in turning this into the generalized WCS, rather it would just become the backend implementation of one specific kind of WCS, so I think we can safely change this without considering too many big picture issues. Though I think this is only worth doing if it's a relatively small project (which I think it is), for that reason.
adrn commentedon Feb 26, 2013
Great!
astrofrog commentedon Sep 20, 2013
@mdboom - so are you suggesting that this should just be closed?
mdboom commentedon Sep 20, 2013
I think now that #1281 is merged, this is less of an issue. We can rename things, but it's a tricky move. The better name for
all_world2pixisworld2pixand that's already taken.And yes, long term, this whole module will become more private behind a general WCS interface, so I don't know how critical this is.