v3.1rc1 - votable failures

Full log in https://gist.github.com/saimn/a823d4223dcd09ffc5fa03627d9b8249

astropy/io/votable/tests/vo_test.py::test_validate FAILED                [ 33%]
astropy/io/votable/tests/vo_test.py::test_validate_xmllint_true PASSED   [ 66%]
astropy/io/votable/tests/vo_test.py::test_validate_path_object FAILED    [100%]

That's annoying...

E         '11: E02: Incorrect number of elements in array. Expected multiple of\n',
E         '  0, got 2\n',
E         -  '<PARAM datatype="float" name="wrong_arraysize" value="0.000000,0.00...\n',
E         ?                                                                      ^^^
E         +  '<PARAM datatype="float" name="wrong_arraysize" value="0.000000,0.0000…\n',
E         ?                                                                      ^^^

Is this Debian? What is your version of xmllint?

@pllim

@pllim - yes, on Debian.

❯ xmllint --version
xmllint: using libxml version 20904
   compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 FTP HTTP DTDValid HTML Legacy C14N Catalog XPath XPointer XInclude Iconv ICU ISO8859X Unicode Regexps Automata Expr Schemas Schematron Modules Debug Zlib Lzma

@olebole

@olebole , is this one of the tests you already disabled in the distro? votable has not been touched much since the last release...

FWIW mine is

xmllint: using libxml version 20908
   compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 FTP HTTP DTDValid
HTML Legacy C14N Catalog XPath XPointer XInclude Iconv ICU ISO8859X Unicode Regexps
Automata Expr Schemas Schematron Modules Debug Zlib Lzma

I tried digging into the validator code but can't find anything obvious.

@saimn

@saimn - Looks like it's due to … (single-character) being used for ellipsis. I wonder if that depends on your locale. What are your locale settings? (output of locale)

I can reproduce this by setting astropy.conf.unicode_output to True

We really should ignore user configuration when running tests...

So just to clarify, this isn't anything to do with votable fundamentally, just the fact that if the user has set local configuration that is different from the default, the tests may fail. So we somehow need to ensure that during testing, the configuration file is ignored.

@saimn

By the way, this may happen only when running tests directly with pytest, I need to check (@saimn can you confirm how you ran the tests?)

@astrofrog

Well guessed @astrofrog, it seems that I did set the unicode_output setting in my config file !
I tested both directly with pytest and with the setup.py.

Okay, so I guess mystery is solved. Now should I

(a) Change the title to "make tests insensitive to locale" here, remove milestone, and label as feature request; OR
(b) Do (a) in a new issue?

See #8154

Navigation Menu

Repository navigation

v3.1rc1 - votable failures #8142

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

v3.1rc1 - votable failures #8142

Description

Activity

pllim commented on Nov 16, 2018

saimn commented on Nov 16, 2018

pllim commented on Nov 16, 2018

pllim commented on Nov 16, 2018

astrofrog commented on Nov 16, 2018

astrofrog commented on Nov 16, 2018

astrofrog commented on Nov 16, 2018

astrofrog commented on Nov 16, 2018

saimn commented on Nov 16, 2018

pllim commented on Nov 17, 2018

pllim commented on Nov 17, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions