Skip to content

WCS should accept / return coordinates objects #812

Closed

Description

@adrn

It might be nice to build in support so that conversions from world coordinates accept any Astropy coordinates object and conversions to world coordinates return a coordinates object as well (once Angle and other coordinate object accept arrays) . For example:

>>> worldcoords = coord.ICRSCoordinates([[151.1241, 11.134], [12.4123, -41.1231]], unit=(u.deg, u.deg))
>>> wcs.wcs_world2pix(worldcoords)
...

I also hate the function names in wcs but I'm not sure there's anything we can do about that..

Activity

  1. mdboom commented on Feb 25, 2013

    @mdboom
    Contributor

    I agree -- this would be nice, and shouldn't be too difficult. As for the naming, I've opened #815 for that.

  2. modified the milestones: v1.0.0, v0.4.0 on May 3, 2014
  3. removed this from the v1.0.0 milestone on Jan 20, 2015
  4. bsipocz commented on Jun 27, 2017

    @bsipocz
    Member

    Isn't this solved now by #2885?

    cc: @adrn @astrofrog

  5. adrn commented on Jun 27, 2017

    @adrn
    MemberAuthor

    I haven't been following...

  6. bsipocz commented on Mar 18, 2019

    @bsipocz
    Member

    I very much still feel that wcs.utils.skycoord_to_pixel(coord, wcs) and wcs.utils.pixel_to_skycoord(x, y, wcs) do implement this feature, so suggest to close the issue.

  7. added
    Close?Tell stale bot that this issue/PR is stale
    on Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Close?Tell stale bot that this issue/PR is stalewcs

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions