Skip to content

Convolution: should NaN interpolation inc. inf? #8099

Open

Description

@jamienoss

In convolution.convolve_fft(), nan_treatment='interpolate' includes the interpolation of infinities. Should convolution.convolve() do so also?

src

...
 # NaN and inf catching
 nanmaskarray = np.isnan(array) | np.isinf(array)
...

src

...
interpolate_nan = (nan_treatment == 'interpolate')
    if interpolate_nan:
        ...
        bigimwt[arrayslices] = 1.0 - nanmaskarray * interpolate_nan
        ...
...

Activity

  1. jamienoss commented on Nov 10, 2018

    @jamienoss
    ContributorAuthor

    #5782 suggests not only that it should but that it already has. This is clearly not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions