Repository navigation
include wcslib 6.2 in release 3.2 #7929
Description
wcslib 6.1 was released:
WCSLIB version 6.1 (2018/10/19)
-------------------------------
* C library
- Added support for time-related WCS keywords (Paper VII) by expanding
the wcsprm struct to store them as auxiliary values, now filled by
the header parsers, wcspih() and wcsbth() and handled routinely by
wcsinit(), wcssub(), wcscompare(), wcsfree(), wcsprt(), wcsset(),
and wcshdo().
- Augmented datfix() to do various consistency checks on the new
time-related keyvalues, and added a new routine, obsfix(), to check
consistency of the OBSGEO-[XYZLBH] observatory coordinates.
- In the usage notes for wcsbth(), clarified that, according to WCS
Papers III and VII, certain global image header keywords are
permitted in binary table headers and are expected to be inherited
by image arrays and pixel lists, and elaborated on the difficulties
that such inheritance may cause for pixel lists.
- Extracted the definition of the wtbarr struct from wcs.h to a
separate header file, wtbarr.h, in order to reduce the number of
irrelevant warnings generated by 'gcc -Wpadded' (primarily for
code development). Applications code that needs to access members
of the struct (unlikely) must now include wtbarr.h (or wcslib.h).
- The WCSLIB major version number was incremented as changes to the
wcsprm struct makes the ABI of the sharable library incompatible
with executables linked with that of older releases.
* Installation
- Several changes to configure and the makefiles aimed at facilitating
code development.
* Fortran wrappers
- Match changes to the C library, including adding a wrapper for
obsfix().
Reacted by Simon Conseil
Activity
nden commentedon Oct 19, 2018
Need to see if this is possible to do given that there are backwards incompatible changes and the deadline for the release is soon.
astrofrog commentedon Oct 19, 2018
Great that the time keywords are supported! We definitely should get this into 3.1 if possible.
olebole commentedon Oct 21, 2018
I just tried to build astropy-3.0.5 using wcslib-6.2; but the tests fail with a segmentation fault:
Backtrace when running with Python-3.7rc2 during pytest startup:
Using wcslib-5.20 in the same environment succeeds.
Quickly checking the changes between 5.20 and 6.2 didn't help me; also API changes were not documented.
saimn commentedon Oct 21, 2018
edit: I did not see the previous comment, so this was just to announce the follow-up version 6.2
olebole commentedon Oct 21, 2018
@saimn I am not sure whether your comment was related to me: I replaced the two
wcs.happearances in astropy with the one from 6.2, without a change. I would also suspect that when using external libs, then also the headers are used from the system.saimn commentedon Oct 21, 2018
@olebole - nope, sorry, I already had the page loaded in the browser and didn't see your comment.
[-]include wcslib 6.1 in release 3.1[/-][+]include wcslib 6.1 in release 3.2[/+]astrofrog commentedon Mar 25, 2019
@nden - will you have any time to try and work on upgrading WCSLIB to 6.1 in time for the feature freeze? I'm working on adding time series functionality to the core package for the 3.2 release, and it would be really helpful to have the new WCS support for time axes.
nden commentedon Apr 15, 2019
@astrofrog I worked on this over the weekend. I still have to figure out four test failures related to error messaging and write tests but am hopeful that I will post a PR before the feature freeze.
astrofrog commentedon Apr 15, 2019
@nden - that's great, thanks!!
[-]include wcslib 6.1 in release 3.2[/-][+]include wcslib 6.2 in release 3.2[/+]