Repository navigation
Documentation of trying development has python2-only stuff #7287
Description
In http://docs.astropy.org/en/latest/development/workflow/get_devel_version.html#activate-the-development-version-of-astropy, it is suggested to run python setup.py develop and it is noted that this is for python2 only. Since we moved to python3, this should be adjusted (to be tested: does this work on python3 now? if not, replace with code showing how to do it in a virtual environment)
Activity
emilydeibert commentedon Mar 16, 2018
This does not work on Python3 right now---I am using Python3 and when I follow the linked instructions the development version will only activate in the distribution directory, but not outside.
kakirastern commentedon Jan 24, 2019
Hi, is it okay for me to work on this issue in preparation for my GSoC 2019 application?
mhvk commentedon Jan 24, 2019
@kakirastern - yes, definitely OK. But please read the discussion in a previous attempt (#7295) and check for yourself what actually works (ideally on different machines). Specifically, there were suggestions to change the shebang on
setup.pytopython3and use./setup.pyor to usepip install -e .Note that the main way this PR allows you to show skills for GSoC is by exploring the above issues yourself (it is clear that making the changes to the text is not difficult).
kakirastern commentedon Jan 24, 2019
Hi @mhvk , thanks for the prompt reply! Yup, I will definitely try it on my laptop to see if it works on my machine. Incidentally, I have both
python2andpython3installed on my computer since I still needpython2to run IRAF for my current studies. My machine's been configured so thatpythonis the same aspython3by the use of an alias... (leavingpython2forpython2and notpythonforpython3). So I think the shebang solution might also depend on software setup/configured. I personally favor thepip install -e .solution for the development version.mhvk commentedon Jan 24, 2019
OK, great! But at least on my machine I'd need to do
pip3 ...- a shebang would be#! /usr/bin/python3. Anyway, trials are the way forward.pllim commentedon Jan 24, 2019
Wait... Is this still an issue after @astrofrog 's rewrite in #8198 ? @astrofrog , that said, does
python setup.py develop -uat the end still applies?mhvk commentedon Jan 24, 2019
@pllim - Looking at the current documentation at http://docs.astropy.org/en/latest/development/workflow/get_devel_version.html#get-devel I see it indeed has changed. But it still has a warning about things not being possible in python3. If this is true, then the whole section should be removed. But I think it is not true, and that it is possible to pip-install under ones own user directory (with
-uindeed).Anyway, @kakirastern, given that the documentation discusses something that supposedly does not work on python3, which is the only python version we support, there definitely is still work to do!
kakirastern commentedon Jan 24, 2019
Awesome, @mhvk! Thanks for the information. I will definitely follow up on the Issue and will open a PR soon. Need to do some investigating around first.
bsipocz commentedon Jan 24, 2019
Hmm, I supposed we've addressed this issue with #8289. If there is still some python3 incompatibility mentioned that most probably should be just simply removed.
@kakirastern - If you are willing to open a PR for that removal that would be great. The assumptions are that everything should work for you locally with Python 3 (aka
python:) ), so the only stuff in the PR is the removal of those notes about incompatibility.bsipocz commentedon Jan 24, 2019
Well,
pipcan be aliased/linked topip3this point, andpip2left as the exception :)kakirastern commentedon Jan 25, 2019
@bsipocz Sure, I am willing to open a PR for the removal of outdated contents, i.e. "those notes about incompatibility". Do you think I should also add some comments about aliasing
python3topythonandpip3topip, respectively? (Sort of like a reminder for people to check their computing setup. Maybe not everyone is aware of it.)bsipocz commentedon Jan 25, 2019
Yes, mentioning the aliasing sounds like a good compromise. Thank you.
kakirastern commentedon Feb 1, 2019
Yup, proposed adding implicit aliasing reference in PR #8385...
mhvk commentedon Jun 2, 2020
fixed a long time ago by #8385