Repository navigation
script 'fitscheck' not deleting CHECKSUM and DATASUM keywords #5874
Description
Astropy v2.0
While working on #5858 I am seeing this particular behavior for fitscheck :-
- Running
fitscheck -v test0.fits(A test file included inastropy/io/fits/tests/data/) which works fine
MISSING './astropy/io/fits/tests/data/test0.fits' .. Checksum not found in HDU #0
1 errors
- Running
fitscheck -v --force --write test0.fits(write correct checksums and datasums for each HDU in file)
MISSING './astropy/io/fits/tests/data/test0.fits' .. Checksum not found in HDU #0
1 errors
Fine too. It first warns then updates
- Now when I run
fitscheck -v --checksum none --write(seeing call trace manually)
AttributeError: 'PrimaryHDU' object has no attribute '_checksum'
This comes from (https://github.com/astropy/astropy/blob/master/astropy/io/fits/scripts/fitscheck.py#L143)
As a matter of fact now that I've added checksums above, it verifies them successfully when I run fitscheck -v test0.fits :-
OK './astropy/io/fits/tests/data/test0.fits'
Is there something I'm missing? Or should I go ahead try to correct this.
Edit : This AttributeError is raised whenever one uses -k none or --checksum none
Activity
[-]script `fitscheck` not deleting `CHECKSUM` and `DATASUM` keywords[/-][+]script 'fitscheck' not deleting CHECKSUM and DATASUM keywords[/+]mohanagr commentedon Mar 12, 2017
After some digging here's what I think the issue is :-
In order for the
CHECKSUMandDATASUMkeywords to be removed, the checksum kwarg should be passed asHDUList.writeto(checksum='remove')notFalseas is done by theFitscheckscript.(https://github.com/astropy/astropy/blob/master/astropy/io/fits/scripts/fitscheck.py#L112)
Since this calls
base._prewriteto()->base._update_checksum()which deletes only whenremoveis the kwarg.Now, as for the error raised, it is raised only when one uses
-k noneoption as I have highlighted in the issue. This is because in (https://github.com/astropy/astropy/blob/master/astropy/io/fits/scripts/fitscheck.py#L135)There we open the fits file, the call stack terminates at
base._readfrom_internal()which is supposed to call_verify checksum_datasum(which setshdu._checksum) but doesn't because the script option "none" sets the checksum kwarg to False. Check the reference below.Reference
(https://github.com/astropy/astropy/blob/master/astropy/io/fits/hdu/base.py#L460)
mohanagr commentedon Mar 12, 2017
@saimn @pllim Should I open a different PR for this or push it in #5858 where I was writing tests for
fitscheck? Thanks.Fix for issue astropy#5874 for fitscheck script not deleting CHECKSUM…
pllim commentedon Mar 13, 2017
I would say bug fix should be a separate PR from adding tests because they are milestoned differently, but looks like you already added the fix into the testing PR.
Fix for issue astropy#5874 for fitscheck script not deleting CHECKSUM…
bsipocz commentedon Sep 25, 2017
Closing, see #6571 for the fix.