Repository navigation
Remove deprecated stuff for v3.0 #5774
Description
This is a follow-up of
- Change deprecated_renamed_argument to allow hiding the deprecations #5761 -- Completely remove the deprecated "clobber" keyword for v3, as discussed. Users must switch to "overwrite" keyword now.
- Deprecate analytic_functions subpackage and move functions to modeling #6191 -- Completely remove
analytic_functionssub-package. Users must switch to modeling for blackbody. - Deprecate GaussianAbsorption1D model #6200 -- Completely remove
GaussianAbsorption1Dmodel. Users can construct such a thing by subtractingGaussian1Dfrom desired continuum model (e.g.,Const1D).
Activity
bsipocz commentedon Feb 5, 2017
@pllim @eteq - What about creating the 3.0 milestone now? There are already a few issues out there that will be relevant for that only, and I think it would be very helpful to milestone the asap to lower the chance of getting lost in the noise of open issues.
pllim commentedon Feb 6, 2017
@bsipocz , looks like @astrofrog added the milestone (thanks, Tom!).
Also, I added "Last-before-release" tags here and in #5773. Is that correct?
MSeifert04 commentedon Feb 6, 2017
I would actually vote for removing
clobberin 4.0 or 3.2. The deprecation is only active for 1 (not-bugfix) release now that it's hidden. I'm not sure but I thought the procedure was 2 (or 3 releases) before a deprecated feature is removed.With 4.0 people would've two major releases and with 3.2 at least they have 3 minor releases before they actually need to change it. (and
io.fitsis widely used and in a lot of scripts).bsipocz commentedon Feb 6, 2017
@MSeifert04 - I think it should be fine to remove it in 3.0. 3.0 will have significantly large changes, like the removal of python2, so people should be careful before upgrading to it. Yet anyone wanting to use clobber, they are able to do so for 2 more years on the 2.x LTS.
bsipocz commentedon Feb 6, 2017
@pllim - Thanks for adding the tag. For #5773 it it critical, here it shouldn't matter much.
[-]Remove clobber from io.fits[/-][+]Remove deprecated stuff for v3.0[/+]