Setting mask on non-masked column should raise error #3505

Activity

1. astrofrog

   added

   table

   on Feb 15, 2015
2. taldcroft commented on Feb 15, 2015

   

   taldcroft

   on Feb 15, 2015

   Member

   More actions

   Agreed.
3. taldcroft commented on Feb 15, 2015

   

   taldcroft

   on Feb 15, 2015

   Member

   More actions

   Seems like a __setattr__ on Column should do the trick. It should just look for item == 'mask' and raise an exception, otherwise fall through to the super method. Offhand I don't think there should be any performance implication, but we need to be sure.
4. taldcroft

   added

   Effort-low

   💤 Package-novice

   on Feb 15, 2015
5. taldcroft commented on Feb 15, 2015

   

   taldcroft

   on Feb 15, 2015

   Member

   More actions

   Can leave this open for GSOC PR.
6. quantshah commented on Feb 15, 2015

   

   quantshah

   on Feb 15, 2015

   More actions

   What message should be issued after AttrributeError is raised ? Will this snippet do the job in astropy/table/column.py ?

   def __setattr__(self,item,value):
           if item == "mask":
               raise AttributeError("Setting mask on non-masked column")
           else:
               return super(Column, self).__setattr__(item, value)

   I got this output with astrofog's test case :

   Traceback (most recent call last):
     File "test.py", line 4, in <module>
       t['a'].mask = [True, False, True]
     File "/home/dev/astropy/astropy/table/column.py", line 780, in __setattr__
       raise AttributeError("Setting mask on non-masked column")
   AttributeError: Setting mask on non-masked column
   
7. mvnnn commented on Feb 24, 2016

   

   mvnnn

   on Feb 24, 2016

   Contributor

   More actions

   that issue is still open? i want to work on this.
8. taldcroft commented on Feb 25, 2016

   

   taldcroft

   on Feb 25, 2016

   Member

   More actions

   @mvnnn - Go ahead. You can take over from #3522 and #4494. Both of those were not implemented correctly.
9. taldcroft

   closed this as completedin #4637on Mar 1, 2016