Repository navigation
test_quantity_array_methods error with numpy release candicate #3471
Description
If the numpy version number has an "rc" in it, some tests give errors because of:
_____ ERROR collecting astropy/units/tests/test_quantity_array_methods.py ______
astropy/units/tests/test_quantity_array_methods.py:11: in <module>
> NUMPY_LT_1P9P1 = [int(x) for x in np.__version__.split('.')[:3]] < [1, 9, 1]
E ValueError: invalid literal for int() with base 10: '0rc1'
Here, Numpy is 1.9.0rc1, Platform is Debian (inofficial) on x32. Full log
Activity
embray commentedon Feb 10, 2015
Thanks--this should probably be fixed by #3389. I was holding back on merging that as it seemed non-critical. But now that there is an actual bug case (as I was worried their might be when I saw that same code, though I had never directly encountered an issue with it) it might be worth merging my fix.
eteq commentedon Feb 10, 2015
@olebole - can you check that #3389 fixed this, and close this if so? Thanks!
olebole commentedon Feb 11, 2015
Sorry, I don't have access to an x32 machine unti tomorrow evening, and the change seems too complicated to just test it somewhere else.
embray commentedon Feb 11, 2015
It should be fixed, in any case. The code that's bugging out there simply no longer exists, and this version comparison is handled correctly by
pkg_resources:olebole commentedon Feb 11, 2015
OK, so I am closing this. If this reappears with 1.0, I will just re-open.
Added changelog entries for #3389. I also reported #3471 as fixed.
Added changelog entries for #3389. I also reported #3471 as fixed.
embray commentedon Feb 11, 2015
I went ahead and reported this as fixed in f04c3a1, but I will roll that back if it turns out not to be somehow.
embray commentedon Feb 11, 2015
Okay, thanks.