Skip to content

Introspectable wheels: configure our test Linux wheel job to upload the artifact to actions #20572

Open

Description

@nstarman

On the topic of checking the wheels: we should configure our test Linux wheel job to upload the artifact to actions so people can download it and check in situations like this.

Originally posted by @Cadair in #20568 (comment)

Activity

  1. Cadair commented on Oct 9, 2026

    @Cadair
    Member

    This is a one line patch to here:

    save_artifacts: true

  2. pllim commented on Oct 9, 2026

    @pllim
    Member

    So it uploads every commit for every PR? Seems excessive.

  3. nstarman commented on Oct 9, 2026

    @nstarman
    MemberAuthor

    Could we do it based on a label?

  4. pllim commented on Oct 9, 2026

    @pllim
    Member

    Wait a minute... Don't we already do that if we slap the "build all wheels" label on a PR?

    save_artifacts: true

  5. nstarman commented on Oct 9, 2026

    @nstarman
    MemberAuthor

    Then I guess the ask is for a smaller set of wheels, e.g. just linux? Don't need the full matrix always

  6. Cadair commented on Oct 9, 2026

    @Cadair
    Member

    We always build the one Linux wheel as part of the regular CI. I'm saying we upload that one.

  7. pllim commented on Oct 9, 2026

    @pllim
    Member

    And I am saying since that one always run no matter what, it might be too much for every commit in every PR. And if you want to control by label, we already have that. So I don't see anything needs to be done here.

  8. Cadair commented on Oct 9, 2026

    @Cadair
    Member

    3. So it uploads every commit for every PR? Seems excessive.

    I don't think uploading one wheel is going to cause any undue stress on the world?

  9. Cadair commented on Oct 9, 2026

    @Cadair
    Member

    It's a 10MB wheel, we are already building it on each run. Might as well save it for a while so it's useful?

  10. Cadair commented on Oct 9, 2026

    @Cadair
    Member

    I'm pretty sure we have unlimited actions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions