You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
MAINT: shape setting should be deprecated in astropy container classes. #19168
incidentally, it seems to me your suggestion for #19182 provides a great migration path for us to resolve this issue; we can split every shape property setter into a deprecated public interface, and a (semi) private _set_shape override. WDYT ?
Yes, agreed, we can simply mimic what numpy offers, allowing people to keep setting shapes if they really need to. And that also allows us to yield our own deprecation warnings (maybe starting in 8.0).
note: I consider this blocked by #19217, because we currently can't really see anything in devdeps CI
If this issue is still open when time comes to prepare 7.2.1, I expect it should be trivial to fix properly, so please do ping us before moving the ticket to the next milestone.
Hi, is this issue open for work now that #19217 is closed?
And just to make sure, when you mentioned everywhere except Masked you meant the Masked family of classes and not only the Masked class correct?
Activity
neutrinoceros commentedon Jan 22, 2026
incidentally, it seems to me your suggestion for #19182 provides a great migration path for us to resolve this issue; we can split every
shapeproperty setter into a deprecated public interface, and a (semi) private_set_shapeoverride. WDYT ?mhvk commentedon Jan 22, 2026
Yes, agreed, we can simply mimic what numpy offers, allowing people to keep setting shapes if they really need to. And that also allows us to yield our own deprecation warnings (maybe starting in 8.0).
neutrinoceros commentedon Feb 2, 2026
note: I consider this blocked by #19217, because we currently can't really see anything in devdeps CI
If this issue is still open when time comes to prepare 7.2.1, I expect it should be trivial to fix properly, so please do ping us before moving the ticket to the next milestone.
Iquecs2005 commentedon May 19, 2026
Hi, is this issue open for work now that #19217 is closed?
And just to make sure, when you mentioned everywhere except Masked you meant the Masked family of classes and not only the Masked class correct?
pllim commentedon May 19, 2026
Not sure why this was milestoned to v7.2.1 originally. I don't think we can deprecate anything now until
mainis set forv9.0.dev?Iquecs2005 commentedon May 19, 2026
Can i make a PR, draft or not, that will close this issue even if it will only be merged when 9.0 rolls around?
pllim commentedon May 19, 2026
Yes, you can make a draft PR but it would sit open for a while.