Skip to content

Add legacy package for io.ascii to asciitable #175

Closed

Description

@taldcroft

Add legacy package to package_setup.py for io.ascii to map to asciitable. (Pending pull request #174).

Activity

  1. astrofrog commented on Apr 8, 2012

    @astrofrog
    Member

    Now that #174 is merged, can this be done?

  2. taldcroft commented on Apr 10, 2012

    @taldcroft
    MemberAuthor

    Yup, will do. If I understand all I need to do is edit setup_package.py in astropy/io/ascii/ and add something like:

    def get_legacy_alias():
        return setup_helpers.add_legacy_alias('asciitable', 'astropy.io.ascii', '0.8.0')

    Is that correct?

  3. astrofrog commented on Apr 10, 2012

    @astrofrog
    Member

    That should be it, but we're discovering some issues with the legacy layers (see #193), so maybe you could hold off until we've resolved that?

  4. taldcroft commented on Apr 10, 2012

    @taldcroft
    MemberAuthor

    I'll wait until further notice.

  5. astrofrog commented on Jun 1, 2012

    @astrofrog
    Member

    Now that #174 and #194 are merged, could you address this issue ahead of 0.1?

  6. taldcroft commented on Jun 1, 2012

    @taldcroft
    MemberAuthor

    @astrofrog - will do over the weekend.

  7. taldcroft commented on Jun 5, 2012

    @taldcroft
    MemberAuthor

    I've decided not to have asciitable as a legacy package of io.ascii. After cutting the cord I was immediately able to clean out a whole bunch of crufty code and start planning for real integration with the Table class. This issue is therefore closed with no action required.

    My current branch for this development (io-ascii) passes tests but I need to scrub docs a bit more to make sure everything is consistent.

    cc\ @eteq @iguananaut @mdboom

  8. added a commit that references this issue on Jun 12, 2019
  9. added a commit that references this issue on Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions