Repository navigation
LombScargle: Implement fit_mean by passing it to the new floating_mean in scipy implementation #17166
Description
As suggested by @jakevdp in #17163 (comment)
It might be worth implementing fit_mean by passing it to the new floating_mean argument of the scipy method, i.e., remove this warning if a suitably new scipy version is installed:
astropy/astropy/timeseries/periodograms/lombscargle/implementations/main.py
Lines 205 to 207 in fefc240
Activity
neutrinoceros commentedon Oct 12, 2024
I'm +1 on doing this, but for posterity: this will require scipy 1.15 or later, assuming the argument isn't renamed or removed in the meantime before the release (unlikely, but still possible), so I think we should wait until this feature lands in a stable version before we start relying on it.
pllim commentedon Nov 10, 2026
#20412