Repository navigation
Reminder: remove astropy.cosmology._utils.deprecated_keywords for astropy 8.0.0 #16614
Description
#16597 introduces a private decorator deprecated_keywords that's meant to ease transitioning positional-or-keyword arguments to positional-only without a sudden API break.
The deprecations introduced in that PR are to land in astropy 7.0.0 .
This issue is to remind ourselves of what should be cleaned after 8.0.0 is branched out:
- all decorators
@deprecated_keywordscan be removed and targeted arguments should be made positional-only at the same time (add, /after the last argument marked as a deprecated keyword and before the first that wasn't) astropy.cosmology._utils.deprecated_keywordsand associated tests can be removedastropy/cosmology/_signature_deprecations.c,astropy/cosmology/setup_packages.pyandlicenses/POSITIONAL_DEFAULTS.rstcan be removed
Reacted by Nathaniel Starkman
Activity
pllim commentedon Jun 26, 2024
I think these should also happen together:
licenses./in the affected function signatures to ensurezcannot be passed as keyword.neutrinoceros commentedon Jun 26, 2024
Your second point is included in my first (I'll clarify), but I didn't think about the license file, thank you !
NathanMuniz18 commentedon Oct 9, 2024
hello guys can i try to help on this?
neutrinoceros commentedon Oct 9, 2024
Thanks for offering @NathanMuniz18, but this needs to wait until astropy v7.0.x is branched out, which is not expected to happen before the end of the month. See https://github.com/astropy/astropy/wiki/Release-Calendar
If you're looking to contribute, please have a look at https://www.astropy.org/contribute.html#code, which has pointers to help you discover manageable issues. Thank you !
NathanMuniz18 commentedon Oct 9, 2024
it's okay i'll look for other issue on link, thanks for answer
pllim commentedon Oct 9, 2024
Longer than that. Also have to wait for v7.1.x and be sure then
mainis actually going to be v8.0.