Skip to content

astropy.utils.introspection.minversion fails when running pytest using the development version #16601

Closed

Description

@Parkerwise

Description

I am trying to get into the world of helping to contribute to Astropy, so if I've made any mistakes with this report let me know! I am working through the development section of the astropy docs and I have gotten to the point where I am testing the developers copy. I am running astropy in a conda environment and I got one failure on astropy.utils.introspection.minversion. The docs said to report this, so that is what I am doing. The conda environment is working just fine, I just figured I should clarify I am not running in my base environment. I also ran a test using tox and got the same failure.

JSON report: report.json

Expected behavior

Install development version of astropy in conda environment using python -m pip install --editable ".[test]"
run pytest in the astropy directory
no test failures

How to Reproduce

  1. clone astropy
  2. create conda environment
  3. run python -m pip install --editable ".[test]"
  4. run pytest in the astropy directory

Versions

platform
--------
platform.platform() = 'Linux-6.9.5-arch1-1-x86_64-with-glibc2.39'
platform.version() = '#1 SMP PREEMPT_DYNAMIC Sun, 16 Jun 2024 19:06:37 +0000'
platform.python_version() = '3.12.4'

packages
--------
astropy              0.1.dev37458+gcacde01
numpy                2.0.0
scipy                1.13.1
matplotlib           3.8.4
pandas               --
pyerfa               2.0.1.4

Activity

  1. github-actions commented on Jun 23, 2024

    @github-actions
    Contributor

    Welcome to Astropy 👋 and thank you for your first issue!

    A project member will respond to you as soon as possible; in the meantime, please double-check the guidelines for submitting issues and make sure you've provided the requested details.

    GitHub issues in the Astropy repository are used to track bug reports and feature requests; If your issue poses a question about how to use Astropy, please instead raise your question in the Astropy Discourse user forum and close this issue.

    If you feel that this issue has not been responded to in a timely manner, please send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail [email protected].

  2. neutrinoceros commented on Jun 23, 2024

    @neutrinoceros
    Contributor

    Hi @Parkerwise, I think I know where your problem is : astropy 0.1.dev37458+gcacde01 is clearly wrong, but indicates that your local copy of the code doesn't include our version tags. Here's how to fix this

    git remote add upstream https://github.com/astropy/astropy.git
    git fetch upstream --tags
    python -m pip install -e .
    

    This may be an oversight in our documentation, in which case we should mention it there.
    Let me know if this is sufficient to get back on track !
    (Also, disclaimer: I typed this message from my phone, and even though I've tried to be careful, the code might still contain typos, but at least it gives you the gist of it!)

  3. Parkerwise commented on Jun 23, 2024

    @Parkerwise
    ContributorAuthor

    thank you @neutrinoceros that resolved the issue! I'll be marking this as closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions