Repository navigation
BUG: MaskedNDArray.__array_ufunc__ breaks for erfa.atioq #16123
Description
Related to (but independent of) #16116. Also discovered while working on #16070
import erfa
import astropy.units as u
from astropy.coordinates.builtin_frames.altaz import AltAz
from astropy.coordinates.erfa_astrom import erfa_astrom
from astropy.coordinates import EarthLocation
from astropy.utils.masked import Masked
obeserved_frame = AltAz(
obstime="2024-02-28 10:33:24.505563",
location=EarthLocation(6378137.0, 0.0, 0.0),
pressure=0.0 << u.hPa,
temperature=0.0 << u.deg_C,
relative_humidity=0.0,
obswl=1.0 << u.micron,
)
astrom = erfa_astrom.get().apco(obeserved_frame)
inputs = (0, 1, astrom)
r1 = erfa.atioq(*inputs) # this works
r2 = erfa.atioq(*(Masked(_) for _ in inputs)) # this doesn'tTraceback (most recent call last):
File "/Users/clm/dev/astropy-project/coordinated/astropy/bugs/16116/g.py", line 25, in <module>
r2 = erfa.atioq(*(Masked(_) for _ in inputs))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/clm/.pyenv/versions/astropy.dev/lib/python3.12/site-packages/erfa/core.py", line 4058, in atioq
aob, zob, hob, dob, rob = ufunc.atioq(ri, di, astrom)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/clm/dev/astropy-project/coordinated/astropy/astropy/utils/masked/core.py", line 807, in __array_ufunc__
mask = self._combine_masks(masks, out=out_mask, where=where_unmasked)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/clm/dev/astropy-project/coordinated/astropy/astropy/utils/masked/core.py", line 704, in _combine_masks
np.logical_or(out, mask, out=out, where=where)
TypeError: Cannot cast array data from dtype([('pmt', '?'), ('eb', '?', (3,)), ('eh', '?', (3,)), ('em', '?'), ('v', '?', (3,)), ('bm1', '?'), ('bpn', '?', (3, 3)), ('along', '?'), ('phi', '?'), ('xpl', '?'), ('ypl', '?'), ('sphi', '?'), ('cphi', '?'), ('diurab', '?'), ('eral', '?'), ('refa', '?'), ('refb', '?')]) to dtype('bool').
Activity
[-]BUG: `Masked.__array_ufunc__` breaks for `era.atioq`[/-][+]BUG: `MaskedNDArray.__array_ufunc__` breaks for `era.atioq`[/+]neutrinoceros commentedon Feb 28, 2024
For what it's worth, I checked that #16121 doesn't fix this.
mhvk commentedon Feb 28, 2024
Yes, this is a different problem, that
__array_ufunc__doesn't work with structured arrays (or, rather, that_combine_masksdoesn't). I think it shouldn't be too hard to fix...neutrinoceros commentedon Feb 28, 2024
I'm happy to have a go at it if needed, but I don't want to step on your toes. Just let me know !
mhvk commentedon Feb 28, 2024
PR is forthcoming...
mhvk commentedon Feb 28, 2024
Fix in #16125 - though built on top of #16120, so best to merge in order & rebase.
[-]BUG: `MaskedNDArray.__array_ufunc__` breaks for `era.atioq`[/-][+]BUG: `MaskedNDArray.__array_ufunc__` breaks for `erfa.atioq`[/+]