Skip to content

MNT: Remove deprecated astropy.utils.console.terminal_size #16056

Open

Description

@pllim

astropy.utils.console.terminal_size was deprecated in v6.1 as per #16045 .

It cannot be removed until astropy v7.2 or after (deprecations have to stay for at least 2 non-bugfix releases, right?). This means, we will not accept such PR to remove it until after v7.2.x (or equivalent if we bump to v8 instead) is branched.

Activity

  1. added
    API changePRs and issues that change an existing API, possibly requiring a deprecation period
    on Feb 16, 2024
  2. neutrinoceros commented on Feb 17, 2024

    @neutrinoceros
    Contributor

    Quoting APE 2

    Major releases every year (or longer). These are releases that can introduce breaking API changes, and should be numbered as x.0.0 (e.g., 6.0.0).

    Any API changes should be preceded by deprecation warnings that should be visible to users for at least a year prior to the API change being carried out.

    My interpretation is that

    • removals can only happen in major releases (so, not 7.2)
    • since this deprecation would land in 6.1, it may be removed in 7.0 on the condition that 7.0 is released a full year after 6.1 or later - otherwise, it should be done in 8.0
  3. pllim commented on Feb 17, 2024

    @pllim
    MemberAuthor

    We don't follow strict semver so I can never keep track. If I understood https://github.com/astropy/astropy-APEs/blob/main/APE2.rst correctly, v8.0 sounds fine. I don't think v7.0 would be a full year after v6.1 (more like 6 months) but I cannot tell the future, so we'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    API changePRs and issues that change an existing API, possibly requiring a deprecation periodutils

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions