TST: astropy.units' tests fail against numpy 2.0 dev  #15690

Activity

1. neutrinoceros

   added

   Bug

   on Dec 7, 2023
2. neutrinoceros commented on Dec 7, 2023

   

   neutrinoceros

   on Dec 7, 2023

   Last edited by neutrinoceros

   ContributorAuthor

   More actions

   Ok here's my script to reproduce this locally even without pre-built binaries

   set -euxo pipefail
   
   # spin up env
   python -m venv .venv
   source .venv/bin/activate
   python -m pip install -U pip
   
   # build numpy from source
   python -m pip install git+https://github.com/numpy/numpy.git
   
   # build pyerfa from source against numpy 2.0 dev
   python -m pip install setuptools setuptools_scm wheel jinja2
   python -m pip install git+https://github.com/liberfa/pyerfa.git --no-build-isolation
   
   # build astropy
   python -m pip install extension-helpers Cython
   python -m pip install -e ".[test]" --no-build-isolation
   
   # run test
   pytest astropy/units/tests/test_quantity_non_ufuncs.py -vvv
3. pllim

   added

   numpy-dev

   on Dec 7, 2023
4. pllim commented on Dec 7, 2023

   

   pllim

   on Dec 7, 2023 · Hidden as resolved

   show commentMore actions
5. neutrinoceros commented on Dec 7, 2023

   

   neutrinoceros

   on Dec 7, 2023

   ContributorAuthor

   More actions

   Does that mean the segfault is gone?

   yes it is. I'm working on adding the missing code in astropy.units

   👍React with 👍1Reacted by P. L. Lim
6. pllim

   assigned

   neutrinoceros

   on Dec 7, 2023
7. neutrinoceros commented on Dec 7, 2023

   

   neutrinoceros

   on Dec 7, 2023

   Last edited by neutrinoceros

   ContributorAuthor

   More actions

   quick note that astropy.units.tests.test_quantity_non_ufuncs.CoverageMeta just grew some blindspots, as it is currently not able to distinguish np.linalg.outer from np.outer. I'll probably need to fix that as well to pass CI.

   edit: turns out this can be dealt with separately, so I opened another issue for it: #15692
8. pllim commented on Dec 7, 2023

   

   pllim

   on Dec 7, 2023

   Member

   More actions

   @mhvk can advise here regarding units hook into numpy internals.
9. neutrinoceros commented on Dec 7, 2023

   

   neutrinoceros

   on Dec 7, 2023

   ContributorAuthor

   More actions

   Good to know ! Although I do have some experience in that area since I did the equivalent job in unyt :)

   👍React with 👍1Reacted by P. L. Lim
10. pllim

    closed this as completedin #15691on Dec 11, 2023