You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
TST: TestFunctionHelpersCompleteness.test_all_included fails with numpy-dev #15465
______________ TestFunctionHelpersCompleteness.test_all_included _______________
self = <astropy.units.tests.test_quantity_non_ufuncs.TestFunctionHelpersCompleteness object at ...>
@needs_array_function
def test_all_included(self):
included_in_helpers = (
SUBCLASS_SAFE_FUNCTIONS
| UNSUPPORTED_FUNCTIONS
| set(FUNCTION_HELPERS.keys())
| set(DISPATCHED_FUNCTIONS.keys())
)
> assert all_wrapped == included_in_helpers
E assert {<function ca...ac26030>, ...} == {<function tr...11ee030>, ...}
...
E Full diff:
E {
...
E <function multi_dot at 0x7f46211cb2f0>,
E + <function diagonal at 0x7f46211cb4f0>,
E <function meshgrid at 0x7f46211cb6b0>,
E + <function trace at 0x7f46211cb730>,
E <function histogram_bin_edges at 0x7f46211d7b70>,
...
E <function squeeze at 0x7f4621a07c30>,
E - <function diagonal at 0x7f4621a07df0>,
E - <function trace at 0x7f4621a14030>,
E <function ravel at 0x7f4621a14230>,
...
E }
astropy/units/tests/test_quantity_non_ufuncs.py:2471: AssertionError
Hmm, seems to be due to adding new definitions of diagonal and trace to np.linalg - numpy/numpy#24887
The two parts come about since my tracking code assumed that the name of every numpy function was unique - and that is now broken, with np.diagonal and np.linalg.diagonal being slightly different.
Activity
mhvk commentedon Oct 11, 2023
Hmm, seems to be due to adding new definitions of
diagonalandtracetonp.linalg- numpy/numpy#24887The two parts come about since my tracking code assumed that the name of every numpy function was unique - and that is now broken, with
np.diagonalandnp.linalg.diagonalbeing slightly different.Anyway, should not be too hard to fix...
mhvk commentedon Oct 11, 2023
See #15469 for (hopefully) a fix.