Repository navigation
Followup from #15121: broadcast in Attribute or Baseframe? #15415
Description
Looking at this code again, I'm indeed not sure it is the
Attributethat should be doing the broadcasting -- I don't like that I have to write a comment thatgetattr(self, key)does the broadcasting, bad code smell! But I think that refactoring is probably best done separately from this PR.
Originally posted by @mhvk in #15121 (comment)
Activity
lpsinger commentedon Oct 3, 2023
@mhvk, I'm happy with the code as it is, or with the refactoring that I originally did in #15121. What is your preference?
mhvk commentedon Oct 3, 2023
I'm also very happy with what we have now merged, and think this issue is a good reminder to think through a bit more clearly how
Attributeshould behave. It is really a question of what is more logical, theAttributehaving to adjust its shape (bit weird, why should it care about the instance? though could see it as an "input parameter"), or the frame/instance dealing with it, but then having to know about where the attribute value is actually stored.For now, my vote is just to let this sit for a bit!
[-]Followup from #15121[/-][+]Followup from #15121: broadcast in Attribute or Baseframe?[/+]