Repository navigation
Create ruff.toml and re-organize the exception codes #14736
Description
This came out of Astropy Coordination Meeting 2023. As pyproject.toml contains more things related to build, it is better to declutter it by moving ruff settings to its own ruff.toml. While we're at it, we should also organize the codes by logical sections so it is easier for future maintainers (e.g., "never un-ignore these ones"). Then we add @nstarman and @WilliamJamieson as codeowners for the new ruff.toml file.
Activity
[-]Create ruff.toml and re-organize the codes[/-][+]Create ruff.toml and re-organize the exception codes[/+]eerovaher commentedon May 3, 2023
Are we planning to have a permanent
ruff.tomlor is this a temporary solution until our Ruff configuration has stabilized (i.e. the rules that could be enforced are not ignored anymore)?nstarman commentedon May 3, 2023
My hope is the latter.
nstarman commentedon May 3, 2023
When we do all the TODOs then the ruff config is relatively short.
mhvk commentedon May 4, 2023
If
pyproject.tomlshould contain only things related to build, then I guess logically theblacksetup should also move out of it. And arguably CI-related stuff too...To be honest, I don't really see the point of moving
ruffout, especially as @nstarman is making steady progress on theTODOitems... (but realize I wasn't at the discussion - sadly, I've not been able to attend much of the meeting, sorry!).nstarman commentedon May 4, 2023
I think there were 2 desires to temporarily move ruff to its own file. First was that we are going to move setup.cfg to the toml and all the ruff activity was a bit of a distraction. Second is to have the Codeowners auto-review request be able to distinguish between ruff and not PRs, while both are seeing activity. When there are fewer TODO we should definitely move ruff back to pyproject.toml!
mhvk commentedon May 4, 2023
OK, sounds good! Especially since the PR is already there...
eerovaher commentedon May 4, 2023
Perhaps it would be better to keep the permanent configuration in
pyproject.tomland only move the TODO items toruff.toml. I will describe this in more detail in the pull request.